Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1389440

[PATCH v3 2/7] drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*()

Show all headers | View raw

Now that drm_fb_helper gets deferred io support, the
drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule
a worker that will call the (struct drm_framebuffer *)->funcs->dirty()
function. This will break this driver so use the
sys_{fillrect,copyarea,imageblit} functions directly.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/qxl/qxl_fb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
index bb7ce07..3f7c543 100644
--- a/drivers/gpu/drm/qxl/qxl_fb.c
+++ b/drivers/gpu/drm/qxl/qxl_fb.c
@@ -199,7 +199,7 @@ static void qxl_fb_fillrect(struct fb_info *info,
 {
 	struct qxl_fbdev *qfbdev = info->par;
 
-	drm_fb_helper_sys_fillrect(info, rect);
+	sys_fillrect(info, rect);
 	qxl_dirty_update(qfbdev, rect->dx, rect->dy, rect->width,
 			 rect->height);
 }
@@ -209,7 +209,7 @@ static void qxl_fb_copyarea(struct fb_info *info,
 {
 	struct qxl_fbdev *qfbdev = info->par;
 
-	drm_fb_helper_sys_copyarea(info, area);
+	sys_copyarea(info, area);
 	qxl_dirty_update(qfbdev, area->dx, area->dy, area->width,
 			 area->height);
 }
@@ -219,7 +219,7 @@ static void qxl_fb_imageblit(struct fb_info *info,
 {
 	struct qxl_fbdev *qfbdev = info->par;
 
-	drm_fb_helper_sys_imageblit(info, image);
+	sys_imageblit(info, image);
 	qxl_dirty_update(qfbdev, image->dx, image->dy, image->width,
 			 image->height);
 }
-- 
2.2.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/7] drm: Add fbdev deferred io support to helpers Noralf Trønnes <noralf@tronnes.org> - 2016-04-27 20:20 +0200
  [PATCH v3 4/7] fbdev: fb_defio: Export fb_deferred_io_mmap Noralf Trønnes <noralf@tronnes.org> - 2016-04-27 20:20 +0200
  [PATCH v3 2/7] drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*() Noralf Trønnes <noralf@tronnes.org> - 2016-04-27 20:20 +0200
  [PATCH v3 7/7] drm/udl: Use drm_fb_helper deferred_io support Noralf Trønnes <noralf@tronnes.org> - 2016-04-27 20:20 +0200
  [PATCH v3 3/7] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes <noralf@tronnes.org> - 2016-04-27 20:20 +0200
    Re: [PATCH v3 3/7] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes <noralf@tronnes.org> - 2016-04-27 21:30 +0200
      Re: [PATCH v3 3/7] drm/fb-helper: Add fb_deferred_io support Daniel Vetter <daniel@ffwll.ch> - 2016-04-28 09:20 +0200
    Re: [PATCH v3 3/7] drm/fb-helper: Add fb_deferred_io support Daniel Vetter <daniel@ffwll.ch> - 2016-04-27 21:30 +0200
  [PATCH v3 5/7] drm/fb-cma-helper: Add fb_deferred_io support Noralf Trønnes <noralf@tronnes.org> - 2016-04-27 20:20 +0200
  [PATCH v3 1/7] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() Noralf Trønnes <noralf@tronnes.org> - 2016-04-27 20:20 +0200
  Re: [PATCH v3 0/7] drm: Add fbdev deferred io support to helpers Daniel Vetter <daniel@ffwll.ch> - 2016-04-27 21:30 +0200
    Re: [PATCH v3 0/7] drm: Add fbdev deferred io support to helpers Noralf Trønnes <noralf@tronnes.org> - 2016-04-27 22:00 +0200
      Re: [PATCH v3 0/7] drm: Add fbdev deferred io support to helpers Daniel Vetter <daniel@ffwll.ch> - 2016-04-28 09:30 +0200

csiph-web