Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1389313

[PATCH v2] cpufreq: st: enable selective initialization based on the platform

Show all headers | View raw

The sti-cpufreq does unconditional registration of the cpufreq-dt driver
which causes issue on an multi-platform build. For example, on Vexpress
TC2 platform, we get the following error on boot:

cpu cpu0: OPP-v2 not supported
cpu cpu0: Not doing voltage scaling
cpu: dev_pm_opp_of_cpumask_add_table: couldn't find opp table
	for cpu:0, -19
cpu cpu0: dev_pm_opp_get_max_volt_latency: Invalid regulator (-6)
...
arm_big_little: bL_cpufreq_register: Failed registering platform driver:
		vexpress-spc, err: -17

The actual driver fails to initialise as cpufreq-dt is probed
successfully, which is incorrect. This issue can happen to any platform
not using cpufreq-dt in a multi-platform build.

This patch adds a check to do selective initialization of the driver.

Cc: Lee Jones <lee.jones@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
Fixes: ab0ea257fc58 ("cpufreq: st: Provide runtime initialised driver for ST's platforms")
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/cpufreq/sti-cpufreq.c | 4 ++++
 1 file changed, 4 insertions(+)

v1->v2:
	- Updated compatible strings as per Lee's confirmation

diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c
index a9c659f58974..04042038ec4b 100644
--- a/drivers/cpufreq/sti-cpufreq.c
+++ b/drivers/cpufreq/sti-cpufreq.c
@@ -259,6 +259,10 @@ static int sti_cpufreq_init(void)
 {
 	int ret;

+	if ((!of_machine_is_compatible("st,stih407")) &&
+		(!of_machine_is_compatible("st,stih410")))
+		return -ENODEV;
+
 	ddata.cpu = get_cpu_device(0);
 	if (!ddata.cpu) {
 		dev_err(ddata.cpu, "Failed to get device for CPU0\n");
--
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: st: enable selective initialization based on the platform Sudeep Holla <sudeep.holla@arm.com> - 2016-04-27 13:50 +0200
  Re: [PATCH] cpufreq: st: enable selective initialization based on  the platform Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-27 13:50 +0200
    Re: [PATCH] cpufreq: st: enable selective initialization based on the  platform Sudeep Holla <sudeep.holla@arm.com> - 2016-04-27 14:50 +0200
  Re: [PATCH] cpufreq: st: enable selective initialization based on  the platform Lee Jones <lee.jones@linaro.org> - 2016-04-27 18:10 +0200
    Re: [PATCH] cpufreq: st: enable selective initialization based on the  platform Sudeep Holla <sudeep.holla@arm.com> - 2016-04-27 18:20 +0200
  [PATCH v2] cpufreq: st: enable selective initialization based on the platform Sudeep Holla <sudeep.holla@arm.com> - 2016-04-27 18:20 +0200
    Re: [PATCH v2] cpufreq: st: enable selective initialization based on  the platform Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-28 04:20 +0200
    Re: [PATCH v2] cpufreq: st: enable selective initialization based on  the platform Lee Jones <lee.jones@linaro.org> - 2016-04-28 09:20 +0200

csiph-web