Re: [BUG] set_pte_at: racy dirty state clearing warning

From	"Shi, Yang" <yang.shi@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [BUG] set_pte_at: racy dirty state clearing warning
Date	2016-04-27 19:00 +0200
Message-ID	<rsAYF-4mv-5@gated-at.bofh.it> (permalink)
References	<rq9pT-7AD-9@gated-at.bofh.it> <rqitc-6j1-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 4/21/2016 1:49 AM, Catalin Marinas wrote:
> On Wed, Apr 20, 2016 at 04:01:39PM -0700, Shi, Yang wrote:
>> When I enable memory comact via
>>
>> # echo 1 > /proc/sys/vm/compact_memory
>>
>> I got the below WARNING:
>>
>> set_pte_at: racy dirty state clearing: 0x0068000099371bd3 ->
>> 0x0068000099371fd3
>> ------------[ cut here ]------------
>> WARNING: CPU: 5 PID: 294 at ./arch/arm64/include/asm/pgtable.h:227
>> ptep_set_access_flags+0x138/0x1b8
>> Modules linked in:
>
> Do you have this patch applied:
>
> http://article.gmane.org/gmane.linux.ports.arm.kernel/492239
>
> It's also queued into -next as commit 66dbd6e61a52.

No, but I just applied it, it works.

Thanks,
Yang

>
>> My kernel has ARM64_HW_AFDBM enabled, but LS2085 is not ARMv8.1.
>>
>> The code shows it just check if ARM64_HW_AFDBM is enabled or not, but
>> doesn't check if the CPU really has such capability.
>>
>> So, it might be better to have the capability checked runtime?
>
> The warnings are there to spot any incorrect uses of the pte accessors
> even before you run on AF/DBM-capable hardware.
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[BUG] set_pte_at: racy dirty state clearing warning "Shi, Yang" <yang.shi@linaro.org> - 2016-04-21 01:10 +0200
  Re: [BUG] set_pte_at: racy dirty state clearing warning Catalin Marinas <catalin.marinas@arm.com> - 2016-04-21 10:50 +0200
    Re: [BUG] set_pte_at: racy dirty state clearing warning "Shi, Yang" <yang.shi@linaro.org> - 2016-04-27 19:00 +0200

csiph-web