Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1389297

Re: [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP enabled

Show all headers | View raw

On Wed, Apr 27, 2016 at 06:18:34PM +0300, Kirill A. Shutemov wrote:
> Okay, I see.
> 
> But do we really want to make PageTransCompoundMap() visiable beyond KVM
> code? It looks like too KVM-specific.

Any other secondary MMU notifier manager (KVM is just one of the many
MMU notifier users) will need the same information if it doesn't want
to run a flood of get_user_pages_fast and it can support multiple
granularity in the secondary MMU mappings, so I think it is justified
to be exposed not just to KVM.

The other option would be to move transparent_hugepage_adjust to
mm/huge_memory.c but that currently has all kind of KVM data
structures in it, so it's definitely not a cut-and-paste work, so I
couldn't do a fix as cleaner as this one for 4.6.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP enabled Andrea Arcangeli <aarcange@redhat.com> - 2016-04-27 14:10 +0200
  Re: [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP  enabled "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-04-27 16:00 +0200
    Re: [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP  enabled Andrea Arcangeli <aarcange@redhat.com> - 2016-04-27 17:10 +0200
      Re: [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP  enabled "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-04-27 17:20 +0200
        Re: [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP  enabled Andrea Arcangeli <aarcange@redhat.com> - 2016-04-27 18:00 +0200
          Re: [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP  enabled Andrea Arcangeli <aarcange@redhat.com> - 2016-04-27 18:10 +0200

csiph-web