Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

From	Hans de Goede <hdegoede@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes
Date	2016-04-27 18:00 +0200
Message-ID	<rsA2D-3Ck-23@gated-at.bofh.it> (permalink)
References	(4 earlier) <rsyNc-2L2-23@gated-at.bofh.it> <rsyWT-2P1-49@gated-at.bofh.it> <rszge-3gp-19@gated-at.bofh.it> <rsA2C-3Ck-9@gated-at.bofh.it> <rsA2C-3Ck-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 27-04-16 17:52, Hans de Goede wrote:
> Hi,
>
> On 27-04-16 17:50, Maxime Ripard wrote:
>> Hi Mark,
>>
>> On Wed, Apr 27, 2016 at 04:01:08PM +0100, Mark Brown wrote:
>>> On Wed, Apr 27, 2016 at 04:40:05PM +0200, Hans de Goede wrote:
>>>
>>>> Or, since regulator_of_get_init_data uses for_each_available_child_of_node
>>>> which checks the "status" value we can actually already use
>>>> "status=disabled" cool. So this simply already works :)
>>>
>>> To repeat you really shouldn't have *any* DT nodes for regulators that
>>> aren't in use, there should be nothing to put in their nodes.  If
>>> there's anything there that's a sign that your DT has problems.
>>
>> How should we deal with regulators that are on by default but are not
>> used in the system then?
>
> I think we've already solved that one, we do list them, thereby giving the
> regulator core permission to touch them and then let the regulator core
> turn them off for us.

To clarify, I do not believe that this is not about not having nodes for
unused regulators, but about not having nodes for regulators which should not
be touched.

Regards,

Hans

Thread

[PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes Hans de Goede <hdegoede@redhat.com> - 2016-04-27 16:10 +0200
  Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in  regulator dts nodes Mark Brown <broonie@kernel.org> - 2016-04-27 16:30 +0200
    Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in  regulator dts nodes Mark Brown <broonie@kernel.org> - 2016-04-27 16:40 +0200
      Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in  regulator dts nodes Hans de Goede <hdegoede@redhat.com> - 2016-04-27 16:50 +0200
        Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in  regulator dts nodes Mark Brown <broonie@kernel.org> - 2016-04-27 17:10 +0200
          Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in  regulator dts nodes Hans de Goede <hdegoede@redhat.com> - 2016-04-27 18:00 +0200
            Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in  regulator dts nodes Hans de Goede <hdegoede@redhat.com> - 2016-04-27 18:00 +0200
              Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in  regulator dts nodes Mark Brown <broonie@kernel.org> - 2016-04-27 18:40 +0200
          Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in  regulator dts nodes Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-04-27 18:00 +0200
    Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in  regulator dts nodes Hans de Goede <hdegoede@redhat.com> - 2016-04-27 16:40 +0200

csiph-web