Re: [PATCH v4 1/2] KVM: remove NULL return path for vcpu ids >= KVM_MAX_VCPUS

From	Cornelia Huck <cornelia.huck@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] KVM: remove NULL return path for vcpu ids >= KVM_MAX_VCPUS
Date	2016-04-26 09:50 +0200
Message-ID	<rs5US-3CS-15@gated-at.bofh.it> (permalink)
References	<rqnCx-1Zd-15@gated-at.bofh.it> <rqnCx-1Zd-17@gated-at.bofh.it>
Organization	IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

Show all headers | View raw

On Thu, 21 Apr 2016 16:15:05 +0200
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:

> Commit c896939f7cff ("KVM: use heuristic for fast VCPU lookup by id") added
> a return path that prevents vcpu ids to exceed KVM_MAX_VCPUS. This is a
> problem for powerpc where vcpu ids can grow up to 8*KVM_MAX_VCPUS.
> 
> This patch simply reverses the logic so that we only try fast path if the
> vcpu id can be tried as an index in kvm->vcpus[]. The slow path is not
> affected by the change.
> 
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
>  include/linux/kvm_host.h |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>

Thread

[PATCH v4 1/2] KVM: remove NULL return path for vcpu ids >=  KVM_MAX_VCPUS Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-04-21 16:20 +0200
  Re: [PATCH v4 1/2] KVM: remove NULL return path for vcpu ids >=  KVM_MAX_VCPUS Cornelia Huck <cornelia.huck@de.ibm.com> - 2016-04-26 09:50 +0200
  Re: [PATCH v4 1/2] KVM: remove NULL return path for vcpu ids >=  KVM_MAX_VCPUS Gerg Kurz <gkurz@linux.vnet.ibm.com> - 2016-04-27 11:50 +0200
    Re: [PATCH v4 1/2] KVM: remove NULL return path for vcpu ids >=  KVM_MAX_VCPUS Radim Krčmář <rkrcmar@redhat.com> - 2016-04-27 16:50 +0200

csiph-web