Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1385900

Re: [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Apr 13, 2016 at 08:11:47PM +0800, Jisheng Zhang wrote:
> Dear Rob,
> 
> On Thu, 7 Apr 2016 12:57:59 -0500 Rob Herring wrote:
> 
> > On Wed, Apr 06, 2016 at 03:28:00PM +0800, Jisheng Zhang wrote:
> > > Sometimes, it's convenient to define the scl's high/low count directly,
> > > e.g HW people would do some measurement then directly give out the
> > > optimum counts. Previously, we solved the sda falling time and scl
> > > falling time by i2c_dw_scl_hcnt() and i2c_dw_scl_lcnt(), then put them
> > > into dt, but what we really care isn't the sda/scl falling time.  
> > 
> > This is just so you can put specific clock count instead of converting 
> > from nanoseconds with standard properties or you gain some additional 
> > control of the timing. If only the former, then I prefer we stick with 
> > the common properties.
> 
> To be honest, both. Let me show how I gain additional control of the timing
> with this patch while I can't do this w/o it.
> 
> I want the similar high percent of SCL high for both standard-mode and
> fast-mode. Before this patch, this is not achievable because the parameters
> to cal the hcnt/lcnt via i2c_dw_scl_hcnt() and i2c_dw_scl_lcnt() are different
> for standard-mode and fast-mode.

If there is something you can't describe currently, then we can add
additional properties to allow you to do what you want. But they should
be generic bindings and not a plain value which is custom to this driver.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low  count from DT Wolfram Sang <wsa@the-dreams.de> - 2016-04-24 22:40 +0200

csiph-web