Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1387033

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

From Alexei Starovoitov <alexei.starovoitov@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl
Date 2016-04-26 02:50 +0200
Message-ID <rrZmp-6LW-5@gated-at.bofh.it> (permalink)
References (5 earlier) <rrV98-3ni-33@gated-at.bofh.it> <rrWRA-4Qn-15@gated-at.bofh.it> <rrYql-63w-1@gated-at.bofh.it> <rrYJI-6tj-7@gated-at.bofh.it> <rrZ34-6Ew-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Apr 25, 2016 at 05:07:26PM -0700, Alexei Starovoitov escreveu:
> > > +	{
> > > +		.procname	= "perf_event_max_stack",
> > > +		.data		= NULL, /* filled in by handler */
> > > +		.maxlen		= sizeof(sysctl_perf_event_max_stack),
> > > +		.mode		= 0644,
> > > +		.proc_handler	= perf_event_max_stack_handler,
> > > +		.extra1		= &zero,
> > > +	},
>  
> > you need to define a max value otherwise perf_callchain_entry__sizeof
> > will overflow. Sure it's root only facility, but still not nice.
> > 1M? Anything above 1M stack frames would be insane anyway.
> > The rest looks good. Thanks!
> 
> Something else? ;-)

all looks good to me. Thanks a bunch!

> 
> commit cd544af4f7fede01cb512d52bb3efe62aa19271d
> Author: Arnaldo Carvalho de Melo <acme@redhat.com>
> Date:   Thu Apr 21 12:28:50 2016 -0300
> 
>     perf core: Allow setting up max frame stack depth via sysctl
>     
>     The default remains 127, which is good for most cases, and not even hit
>     most of the time, but then for some cases, as reported by Brendan, 1024+
>     deep frames are appearing on the radar for things like groovy, ruby.
>     
>     And in some workloads putting a _lower_ cap on this may make sense. One
>     that is per event still needs to be put in place tho.
>     
>     The new file is:
>     
>       # cat /proc/sys/kernel/perf_event_max_stack
>       127
>     
>     Chaging it:
>     
>       # echo 256 > /proc/sys/kernel/perf_event_max_stack
>       # cat /proc/sys/kernel/perf_event_max_stack
>       256
>     
>     But as soon as there is some event using callchains we get:
>     
>       # echo 512 > /proc/sys/kernel/perf_event_max_stack
>       -bash: echo: write error: Device or resource busy
>       #
>     
>     Because we only allocate the callchain percpu data structures when there
>     is a user, which allows for changing the max easily, its just a matter
>     of having no callchain users at that point.
>     
>     Reported-and-Tested-by: Brendan Gregg <brendan.d.gregg@gmail.com>
>     Acked-by: Alexei Starovoitov <ast@kernel.org>

yep :)
hopefully Brendan can give it another spin.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH/RFC] perf core: Allow setting up max frame stack depth via  sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-21 00:50 +0200
  Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth  via sysctl Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-04-21 01:10 +0200
    [PATCH/RFC v2] perf core: Allow setting up max frame stack depth via  sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-22 23:00 +0200
      Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-04-22 23:40 +0200
      Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl David Ahern <dsahern@gmail.com> - 2016-04-23 00:10 +0200
        Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-04-23 00:20 +0200
          Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-25 18:20 +0200
            Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-25 18:30 +0200
              Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-25 21:30 +0200
                Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-04-25 22:10 +0200
                Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-25 22:20 +0200
                Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-04-26 00:10 +0200
                Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-26 01:50 +0200
                Re: [PATCH/RFC v2] perf core: Allow setting up max frame stack depth  via sysctl Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-04-26 02:10 +0200
                [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via  sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-26 02:30 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-26 02:50 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Brendan Gregg <brendan.d.gregg@gmail.com> - 2016-04-26 03:00 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-26 18:40 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl David Ahern <dsahern@gmail.com> - 2016-04-26 18:50 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-27 15:30 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Brendan Gregg <brendan.d.gregg@gmail.com> - 2016-04-26 22:10 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-26 23:10 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Peter Zijlstra <peterz@infradead.org> - 2016-04-27 00:00 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-27 15:00 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Brendan Gregg <brendan.d.gregg@gmail.com> - 2016-04-27 00:00 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Peter Zijlstra <peterz@infradead.org> - 2016-04-27 00:20 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-27 15:00 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-04-26 02:50 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-27 00:00 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-27 15:00 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl Frederic Weisbecker <fweisbec@gmail.com> - 2016-04-27 18:10 +0200
                Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth  via sysctl David Ahern <dsahern@gmail.com> - 2016-04-27 18:30 +0200
                [tip:perf/core] perf core: Allow setting up max frame stack depth  via sysctl tip-bot for Arnaldo Carvalho de Melo <tipbot@zytor.com> - 2016-04-27 17:50 +0200
  Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth via  sysctl David Ahern <dsahern@gmail.com> - 2016-04-21 01:20 +0200
    Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-21 02:20 +0200
  Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth  via sysctl Peter Zijlstra <peterz@infradead.org> - 2016-04-21 13:00 +0200
    Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-21 17:20 +0200
      Re: [PATCH/RFC] perf core: Allow setting up max frame stack depth  via sysctl Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-21 17:50 +0200

csiph-web