Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386938

Re: [PATCH] mm/zpool: use workqueue for zpool_destroy

Show all headers | View raw

On Mon, 25 Apr 2016 17:20:10 -0400 Dan Streetman <ddstreet@ieee.org> wrote:

> Add a work_struct to struct zpool, and change zpool_destroy_pool to
> defer calling the pool implementation destroy.
> 
> The zsmalloc pool destroy function, which is one of the zpool
> implementations, may sleep during destruction of the pool.  However
> zswap, which uses zpool, may call zpool_destroy_pool from atomic
> context.  So we need to defer the call to the zpool implementation
> to destroy the pool.
> 
> This is essentially the same as Yu Zhao's proposed patch to zsmalloc,
> but moved to zpool.

OK, but the refrain remains the same: what are the runtime effects of
the change?  Are real people in real worlds seeing scary kernel
warnings?  Deadlocks?

This info is needed so that I and others can decide which kernel
version(s) should be patched.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/zpool: use workqueue for zpool_destroy Dan Streetman <ddstreet@ieee.org> - 2016-04-25 23:30 +0200
  Re: [PATCH] mm/zpool: use workqueue for zpool_destroy Andrew Morton <akpm@linux-foundation.org> - 2016-04-25 23:50 +0200
  Re: [PATCH] mm/zpool: use workqueue for zpool_destroy Yu Zhao <yuzhao@google.com> - 2016-04-26 00:20 +0200
    Re: [PATCH] mm/zpool: use workqueue for zpool_destroy Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-04-26 03:00 +0200
    Re: [PATCH] mm/zpool: use workqueue for zpool_destroy Dan Streetman <ddstreet@ieee.org> - 2016-04-26 13:10 +0200
  [PATCH] mm/zswap: use workqueue to destroy pool Dan Streetman <ddstreet@ieee.org> - 2016-04-26 23:20 +0200
    Re: [PATCH] mm/zswap: use workqueue to destroy pool Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-04-27 03:00 +0200
      Re: [PATCH] mm/zswap: use workqueue to destroy pool Dan Streetman <ddstreet@ieee.org> - 2016-04-27 19:20 +0200
        Re: [PATCH] mm/zswap: use workqueue to destroy pool Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-04-28 03:40 +0200
          Re: [PATCH] mm/zswap: use workqueue to destroy pool Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-04-28 06:10 +0200
          Re: [PATCH] mm/zswap: use workqueue to destroy pool Dan Streetman <ddstreet@ieee.org> - 2016-04-28 10:30 +0200
        [PATCH] mm/zswap: provide unique zpool name Dan Streetman <ddstreet@ieee.org> - 2016-04-28 11:20 +0200

csiph-web