Re: [PATCH v7 02/15] i2c: octeon: Use i2c recovery framework

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 02/15] i2c: octeon: Use i2c recovery framework
Date	2016-04-25 23:30 +0200
Message-ID	<rrWeS-49v-23@gated-at.bofh.it> (permalink)
References	<rrPQ6-7se-7@gated-at.bofh.it> <rrPQ5-7se-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Apr 25, 2016 at 04:33:31PM +0200, Jan Glauber wrote:
> Switch to the i2c bus recovery framework using generic SCL recovery.
> If this fails try to reset the hardware. The recovery is triggered
> during START on timeout of the interrupt or failure to reach
> the START / repeated-START condition.
> 
> The START function is moved to xfer and while at it remove the
> xfer debug message (i2c core already provides a debug message
> for this).
> 
> Signed-off-by: Jan Glauber <jglauber@cavium.com>

Applied to for-next, thanks!

Fixed this checkpatch warning:

CHECK: Please don't use multiple blank lines
#32: FILE: drivers/i2c/busses/i2c-octeon.c:157:

> +	return (ret) ? ret : -EAGAIN;

I'd write 'return ret ?: -EAGAIN' but this is a 'mileage varies' thing.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 02/15] i2c: octeon: Use i2c recovery framework Jan Glauber <jglauber@cavium.com> - 2016-04-25 16:40 +0200
  Re: [PATCH v7 02/15] i2c: octeon: Use i2c recovery framework Wolfram Sang <wsa@the-dreams.de> - 2016-04-25 23:30 +0200

csiph-web