Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Stefan Berger <stefanb@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core
Date	Mon, 25 Apr 2016 21:20:02 +0200
Message-ID	<rrUd4-2DB-9@gated-at.bofh.it> (permalink)
References	<rpl9L-Ut-3@gated-at.bofh.it> <rpl9L-Ut-1@gated-at.bofh.it> <rqKSu-3S9-9@gated-at.bofh.it>
X-Ibm-Helo	d01dlp03.pok.ibm.com
X-Ibm-Mailfrom	stefanb@linux.vnet.ibm.com
X-Ibm-Rcptto	linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
X-Tm-As-Mml	disable
X-Content-Scanned	Fidelis XPS MAILER
X-Cbid	16042519-0057-0000-0000-000004241E4C
X-Ibm-Av-Detection	SAVI=unused REMOTE=unused XFE=unused
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	tpmdd-devel@lists.sourceforge.net, jgunthorpe@obsidianresearch.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 25 Apr 2016 15:13:26 -0400
X-Original-Message-ID	<571E6C56.4080305@linux.vnet.ibm.com>
X-Original-References	<1461000376-2888-1-git-send-email-stefanb@linux.vnet.ibm.com> <1461000376-2888-2-git-send-email-stefanb@linux.vnet.ibm.com> <20160422150645.GA21128@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1386770

Show key headers only | View raw

On 04/22/2016 11:06 AM, Jarkko Sakkinen wrote:
> On Mon, Apr 18, 2016 at 01:26:13PM -0400, Stefan Berger wrote:
>> From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>>
>> The final thing preventing this was the way the sysfs files were
>> attached to the pdev. Follow the approach developed for ppi and move
>> the sysfs files to the chip->dev with symlinks from the pdev
>> for compatibility. Everything in the core now sanely uses container_of
>> to get the chip.
>>
>> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> Three configurations:
>
> * Haswell NUC with PTT (tpm_crb)
> * Another NUC with dTPM 2.0 chip
> * Dell E6420, which has TPM 1.2 chip
>
> Things seem to be unbroken.
>
> Stefan, have you verified that sysfs attributes work through routes:
>
> 1. From char device sysfs directory
> 2. Through link

Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

>
> An also tried insmod/rmmod couple of rounds?

Works as-is in polling mode but requires Jason's patch "tpm: Fix IRQ 
unwind ordering in TIS" for interrupt mode to not throw errors on 'rmmod'.

Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

Thread

[PATCH v11 0/4] Multi-instance vTPM proxy driver Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-18 19:30 +0200
  [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-18 19:30 +0200
    Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-19 12:20 +0200
      Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-19 12:40 +0200
        Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-04-19 19:10 +0200
          Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-20 07:40 +0200
        Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-19 19:30 +0200
    Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-22 17:10 +0200
      Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-25 21:20 +0200
  [PATCH v11 4/4] tpm: Add documentation for the tpm_vtpm_proxy device driver Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-18 19:30 +0200
    Re: [PATCH v11 4/4] tpm: Add documentation for the tpm_vtpm_proxy  device driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-22 18:50 +0200
  [PATCH v11 3/4] tpm: Proxy driver for supporting multiple emulated TPMs Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-18 19:30 +0200
    Re: [PATCH v11 3/4] tpm: Proxy driver for supporting multiple  emulated TPMs Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-22 18:50 +0200
  [PATCH v11 2/4] tpm: Introduce TPM_CHIP_FLAG_VIRTUAL Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-18 19:30 +0200
    Re: [PATCH v11 2/4] tpm: Introduce TPM_CHIP_FLAG_VIRTUAL Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-22 18:50 +0200
  Re: [PATCH v11 0/4] Multi-instance vTPM proxy driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-22 19:00 +0200
    Re: [tpmdd-devel] [PATCH v11 0/4] Multi-instance vTPM proxy driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-26 11:30 +0200
      Re: [tpmdd-devel] [PATCH v11 0/4] Multi-instance vTPM proxy driver Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-26 13:40 +0200
        Re: [tpmdd-devel] [PATCH v11 0/4] Multi-instance vTPM proxy driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-27 15:00 +0200
          Re: [tpmdd-devel] [PATCH v11 0/4] Multi-instance vTPM proxy driver Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-27 18:30 +0200

csiph-web