Re: [PATCH 2/2] mfd: twl6040: Check clk_prepare_enable() return value in twl6040_power()

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mfd: twl6040: Check clk_prepare_enable() return value in twl6040_power()
Date	2016-04-25 18:20 +0200
Message-ID	<rrRoT-mn-9@gated-at.bofh.it> (permalink)
References	<rq253-1rF-7@gated-at.bofh.it> <rq253-1rF-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 20 Apr 2016, Javier Martinez Canillas wrote:

> The clk_prepare_enable() function can fail so check the return
> value and propagate the error in case of a failure.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
>  drivers/mfd/twl6040.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index 4de92c16dfb8..852d5874aabb 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -291,7 +291,11 @@ int twl6040_power(struct twl6040 *twl6040, int on)
>  		if (twl6040->power_count++)
>  			goto out;
>  
> -		clk_prepare_enable(twl6040->clk32k);
> +		ret = clk_prepare_enable(twl6040->clk32k);
> +		if (ret) {
> +			twl6040->power_count = 0;
> +			goto out;
> +		}
>  
>  		/* Allow writes to the chip */
>  		regcache_cache_only(twl6040->regmap, false);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mfd: twl6040: Check clk_prepare_enable() return value in twl6040_power() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-20 17:20 +0200
  Re: [PATCH 2/2] mfd: twl6040: Check clk_prepare_enable() return  value in twl6040_power() Lee Jones <lee.jones@linaro.org> - 2016-04-25 18:20 +0200

csiph-web