Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1386622
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption |
| Date | 2016-04-25 18:10 +0200 |
| Message-ID | <rrRfd-hZ-29@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <rrPwK-7gP-17@gated-at.bofh.it> <rrPwK-7gP-31@gated-at.bofh.it> <rrPGq-7oh-33@gated-at.bofh.it> <rrPGq-7oh-37@gated-at.bofh.it> <rrR5x-8ma-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Apr 25, 2016 at 04:59:22PM +0100, Matt Fleming wrote: > On Mon, 25 Apr, at 03:27:35PM, Mark Rutland wrote: > > > > I have no strong preference so long as the code is correct. > > > > Another option is to get rid of the bool entirely: > > > > flags ^= cur_flags; > > if (!WARN_ON(flags & ARCH_EFI_IRQ_FLAGS_MASK)) > > return; > > OK, let's do the following because we need flags to be preserved for > printing, > > --- > > unsigned long cur_flags, mismatch; > > local_save_flags(cur_flags); > > mismatch = flags ^ cur_flags; > if (!WARN_ON_ONCE(mismatch & ARCH_EFI_IRQ_FLAGS_MASK)) > return; > Sure; that looks good to me. Cheers, Mark.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv3 0/5] efi: detect erroneous firmware IRQ manipulation Mark Rutland <mark.rutland@arm.com> - 2016-04-25 15:50 +0200
[PATCHv3 3/5] arm/efi: enable runtime call flag checking Mark Rutland <mark.rutland@arm.com> - 2016-04-25 15:50 +0200
[PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Mark Rutland <mark.rutland@arm.com> - 2016-04-25 15:50 +0200
Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Robin Murphy <robin.murphy@arm.com> - 2016-04-25 16:20 +0200
Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-25 16:20 +0200
Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-04-25 16:20 +0200
Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-25 16:30 +0200
Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Mark Rutland <mark.rutland@arm.com> - 2016-04-25 16:30 +0200
Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-25 18:00 +0200
Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption Mark Rutland <mark.rutland@arm.com> - 2016-04-25 18:10 +0200
Re: [PATCHv3 0/5] efi: detect erroneous firmware IRQ manipulation Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-25 18:10 +0200
csiph-web