Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386564

Re: [PATCH v2] z3fold: the 3-fold allocator for compressed pages

Show all headers | View raw

On Mon, Apr 25, 2016 at 9:28 AM, Vlastimil Babka <vbabka@suse.cz> wrote:
> On 04/22/2016 01:22 AM, Andrew Morton wrote:
<snip>
>>
>> So...  why don't we just replace zbud with z3fold?  (Update the changelog
>> to answer this rather obvious question, please!)
>
>
> There was discussion between Seth and Vitaly on v1. Without me knowing the
> details myself, it looked like Seth's objections were addressed, but then
> the thread died. I think there should first be a more clear answer from Seth
> whether z3fold really looks like a clear win (i.e. not workload-dependent)
> over zbud, in which case zbud could be extended?

I have tried to address this question in the changelog for v3 which came out
today. Basically I'd like to play on the safe side and have z3fold
co-existing with
zbud for a while, since zbud is a simple and proven solution which has less
object code and can work without ZPOOL. The original zbud implementation
doesn't use struct page's fields in any way, which z3fold can't get
away without.

As a matter of fact, I don't think there's much of the similar code left between
zbud and z3fold, other than the generic structure.

~vitaly

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] z3fold: the 3-fold allocator for compressed pages Vitaly Wool <vitalywool@gmail.com> - 2016-04-19 11:50 +0200
  Re: [PATCH v2] z3fold: the 3-fold allocator for compressed pages Andrew Morton <akpm@linux-foundation.org> - 2016-04-22 01:30 +0200
    Re: [PATCH v2] z3fold: the 3-fold allocator for compressed pages Vlastimil Babka <vbabka@suse.cz> - 2016-04-25 09:30 +0200
      Re: [PATCH v2] z3fold: the 3-fold allocator for compressed pages Seth Jennings <sjenning@redhat.com> - 2016-04-25 17:00 +0200
      Re: [PATCH v2] z3fold: the 3-fold allocator for compressed pages Vitaly Wool <vitalywool@gmail.com> - 2016-04-25 17:10 +0200

csiph-web