Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386534

Re: [PATCH v3] sched/cpufreq: optimize cpufreq update kicker to avoid update multiple times

Show all headers | View raw

On Fri, Apr 22, 2016 at 02:04:56PM +0200, Rafael J. Wysocki wrote:
> [Added linux-pm to the CC - can you please do so for PM-related patches in
> the future?]
> 
> On 4/22/2016 11:07 AM, Wanpeng Li wrote:
> >From: Wanpeng Li <wanpeng.li@hotmail.com>
> >
> >Sometimes delta_exec is 0 due to update_curr() is called multiple times,
> >this is captured by:
> >
> >	u64 delta_exec = rq_clock_task(rq) - curr->se.exec_start;
> >
> >This patch optimizes the cpufreq update kicker by bailing out when nothing
> >changed, it will benefit the upcoming schedutil, since otherwise it will
> >(over)react to the special util/max combination.
> >
> >Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> 
> The changelog looks better now, thanks!
> 
> Peter, do I think correctly that you're going to take care of this one?  Or
> do you want me to take it?

YEah, looks fine. I'll take it.

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] sched/cpufreq: optimize cpufreq update kicker to avoid update multiple times Wanpeng Li <kernellwp@gmail.com> - 2016-04-22 11:10 +0200
  Re: [PATCH v3] sched/cpufreq: optimize cpufreq update kicker to avoid  update multiple times "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> - 2016-04-22 14:10 +0200
    Re: [PATCH v3] sched/cpufreq: optimize cpufreq update kicker to  avoid update multiple times Peter Zijlstra <peterz@infradead.org> - 2016-04-25 16:40 +0200
  [tip:sched/core] sched/cpufreq: Optimize cpufreq update kicker to  avoid update multiple times tip-bot for Wanpeng Li <tipbot@zytor.com> - 2016-04-28 12:30 +0200

csiph-web