Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386460

Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes

Show all headers | View raw

On 04/25/2016 03:39 PM, Antonio Quartulli wrote:
> On Mon, Apr 25, 2016 at 03:25:22PM +0200, Denys Vlasenko wrote:
>> This function compiles to 473 bytes of machine code.
>> 21 callsites.
>>
>>     text     data      bss       dec     hex filename
>> 95903266 20860288 35991552 152755106 91adba2 vmlinux_before
>> 95894242 20860288 35991552 152746082 91ab862 vmlinux
> 
> Hi Danys,
> 
> thanks for your patch. This function is used in a several performance critical
> code paths (i.e. packet forwarding).
> 
> Are we sure we are not losing in performance here?

Is this a common case?

	if (!hash)
		return NULL;

If yes, then we can inline this part only.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2016-04-25 15:30 +0200
  Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024  bytes Denys Vlasenko <dvlasenk@redhat.com> - 2016-04-25 15:50 +0200
    Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024  bytes Antonio Quartulli <a@unstable.cc> - 2016-04-25 16:30 +0200
  Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024  bytes Antonio Quartulli <a@unstable.cc> - 2016-04-25 16:10 +0200

csiph-web