Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver
Date	2016-04-25 15:00 +0200
Message-ID	<rrOhl-643-19@gated-at.bofh.it> (permalink)
References	<rqiCR-6mQ-5@gated-at.bofh.it> <rqS3E-13B-7@gated-at.bofh.it> <rrF4m-7bR-15@gated-at.bofh.it> <rrOhk-643-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 25-04-16, 14:53, Arnd Bergmann wrote:
> On Monday 25 April 2016 08:30:41 Viresh Kumar wrote:

> I realize that the ordering is fixed through the way that the kernel
> is linked, my worry is more about someone changing the code in some
> way because it's not obvious from reading the code that the
> dependency exists. If either the armada_xp_pmsu_cpufreq_init()
> initcall gets changed so it does not always get called, or the
> cpufreq_dt_platdev_init() initcall gets changed so it comes a little
> earlier, things will break.

cpufreq-dt will just error out in that case, because it wouldn't find
any OPPs registered to the OPP-core. It *shouldn't* crash and if it
does, then we have a problem to fix.

> > The other thing that can happen is that armada_xp_pmsu_cpufreq_init()
> > call can fail. In that case, most of the times cpufreq-dt ->init()
> > will fail as well, so even that is fine for me.
> > 
> > And, so I think we can keep this patch as is.
> 
> What are the downsides of moving armada_xp_pmsu_cpufreq_init()
> into drivers/cpufreq?

More special code :)

-- 
viresh

Thread

[PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-21 11:10 +0200
  Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Arnd Bergmann <arnd@arndb.de> - 2016-04-23 00:50 +0200
    Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-25 05:10 +0200
      Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Arnd Bergmann <arnd@arndb.de> - 2016-04-25 15:00 +0200
        Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-25 15:00 +0200
          Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Arnd Bergmann <arnd@arndb.de> - 2016-04-25 17:30 +0200
            Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-25 17:30 +0200
              Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Arnd Bergmann <arnd@arndb.de> - 2016-04-25 17:50 +0200
                Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-04-25 18:00 +0200

csiph-web