Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables
Date	2016-04-25 12:20 +0200
Message-ID	<rrLMv-406-19@gated-at.bofh.it> (permalink)
References	<rqGvw-qK-23@gated-at.bofh.it> <rqGvw-qK-21@gated-at.bofh.it> <rrLCO-3W5-9@gated-at.bofh.it> <rrLCO-3W5-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Apr 25, 2016 at 03:23:22PM +0530, Laxman Dewangan wrote:
> 
> On Monday 25 April 2016 03:30 PM, Thierry Reding wrote:
> > * PGP Signed by an unknown key
> > 
> > On Fri, Apr 22, 2016 at 03:39:13PM +0530, Laxman Dewangan wrote:
> > [...]
> > > diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> > [...]
> > >   static struct gpio_chip tegra_gpio_chip = {
> > This variable is still file-scoped. Why not get rid of it at the same
> > time? It's rather pointless to remove all file-scoped variables except a
> > single one, because now the driver still isn't properly equipped to deal
> > with multiple instances (however theoretical that may be).
> > 
> 
> Yaah, Alex also pointed that to have the instance of gpio_chip in
> tegra_gpio_info and then do as
> tgi->gc = tegra_gpio_chip.
> 
> 
> same for irq_chip also.
> 
> 
> I hope this will resolve the concern.

An alternative would be to do away with tegra_gpio_chip altogether and
instead assign the fields directly within ->probe(). Both patterns seem
to be used in drivers/gpio, with the latter one being slightly more
common.

Thierry

Thread

[PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-22 12:30 +0200
  Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables Alexandre Courbot <gnurou@gmail.com> - 2016-04-25 07:20 +0200
    Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global  variables Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-25 10:50 +0200
  Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global  variables Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-25 12:10 +0200
    Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global  variables Thierry Reding <thierry.reding@gmail.com> - 2016-04-25 12:20 +0200
  Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global  variables Thierry Reding <thierry.reding@gmail.com> - 2016-04-25 12:10 +0200

csiph-web