Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386145

Re: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support

Show all headers | View raw

On Thu, 21 Apr 2016, Appana Durga Kedareswara Rao wrote:
> > -----Original Message-----
> > From: dmaengine-owner@vger.kernel.org [mailto:dmaengine-
> > owner@vger.kernel.org] On Behalf Of Peter Griffin
> > Sent: Thursday, April 21, 2016 4:34 PM
> > To: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > srinivas.kandagatla@gmail.com; maxime.coquelin@st.com;
> > patrice.chotard@st.com; vinod.koul@intel.com
> > Cc: peter.griffin@linaro.org; lee.jones@linaro.org;
> > dmaengine@vger.kernel.org; devicetree@vger.kernel.org; arnd@arndb.de;
> > broonie@kernel.org; ludovic.barre@st.com
> > Subject: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA
> > engine driver support

What is this text?  If you wish to contribute to upstream mailing
lists, please fix your email client.  Also, please read:

  Documentation/email-clients.txt

> > This patch adds support for the Flexible Direct Memory Access (FDMA) core
> > driver. The FDMA is a slim core CPU with a dedicated firmware.
> > It is a general purpose DMA controller capable of supporting 16
> > independent DMA channels. Data moves maybe from memory to memory
> > or between memory and paced latency critical real time targets and it
> > is found on al STi based chipsets.
> > 
> > Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> >  drivers/dma/Kconfig   |  12 +
> >  drivers/dma/Makefile  |   1 +
> >  drivers/dma/st_fdma.c | 967
> > ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 980 insertions(+)
> >  create mode 100644 drivers/dma/st_fdma.c

[...]
> > +static int st_fdma_clk_enable(struct st_fdma_dev *fdev)
> > +{
> > +	int i, ret;
> > +
> > +	for (i = 0; i < CLK_MAX_NUM; i++) {
> > +		ret = clk_prepare_enable(fdev->clks[i]);
> > +		if (ret < 0)
> 
> You should disable and unprepared the other clocks...

Replying to a 1000 line email and not snipping (especially for a one
single-line comment), it considered bad etiquette.  Please remove all
unrelated text in future.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/18]  Add support for FDMA DMA controller found on STi chipsets Peter Griffin <peter.griffin@linaro.org> - 2016-04-21 13:20 +0200
  [PATCH 06/18] ARM: STi: DT: STiH407: Add FDMA driver dt nodes. Peter Griffin <peter.griffin@linaro.org> - 2016-04-21 13:20 +0200
  [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin <peter.griffin@linaro.org> - 2016-04-21 13:20 +0200
    RE: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-04-21 13:30 +0200
      Re: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Peter Griffin <peter.griffin@linaro.org> - 2016-04-21 17:00 +0200
      Re: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Lee Jones <lee.jones@linaro.org> - 2016-04-25 11:10 +0200
    Re: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Arnd Bergmann <arnd@arndb.de> - 2016-04-21 13:30 +0200
    Re: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Vinod Koul <vinod.koul@intel.com> - 2016-04-26 19:00 +0200
      Re: [PATCH 03/18] dmaengine: st_fdma: Add STMicroelectronics FDMA  engine driver support Peter Griffin <peter.griffin@linaro.org> - 2016-04-27 15:00 +0200
  [PATCH 04/18] dmaengine: st_fdma: Add xp70 firmware loading mechanism. Peter Griffin <peter.griffin@linaro.org> - 2016-04-21 13:20 +0200
    Re: [PATCH 04/18] dmaengine: st_fdma: Add xp70 firmware loading  mechanism. Vinod Koul <vinod.koul@intel.com> - 2016-04-26 19:00 +0200

csiph-web