Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386002

RE: [PATCH 1/6] bus: Add shared MDIO bus framework

Show all headers | View raw

Hi David,

Thanks for providing input over the patch.  Will address the comment as
described below.

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: 24 April 2016 23:48
> To: pramod.kumar@broadcom.com
> Cc: robh+dt@kernel.org; catalin.marinas@arm.com; will.deacon@arm.com;
> yamada.masahiro@socionext.com; wens@csie.org; bcm-kernel-feedback-
> list@broadcom.com; pawel.moll@arm.com; mark.rutland@arm.com;
> arnd@arndb.de; suzuki.poulose@arm.com; punit.agrawal@arm.com;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org; anup.patel@broadcom.com
> Subject: Re: [PATCH 1/6] bus: Add shared MDIO bus framework
>
> From: Pramod Kumar <pramod.kumar@broadcom.com>
> Date: Thu, 21 Apr 2016 14:48:38 +0530
>
> > +struct shared_mdio_master *shared_mdio_alloc_master(struct device
> *parent,
> > +						    struct device_node
*node)
> > +{
> > +	int ret = 0;
> > +	struct shared_mdio_master *master;
>
> Always order local variable declarations in reverse christmas tree
(longest to
> shortest line) order.
>

Sure. Next patch will address this.

> > +static int shared_mdio_driver_probe(struct device *dev) {
> > +	int rc;
> > +	struct shared_mdio_master *master = to_shared_mdio_master(dev);
> > +	struct shared_mdio_driver *drv =
to_shared_mdio_driver(dev->driver);
>
> Likewise.

Sure.

> Please audit your entire submission for this issue.

Sure. I'll audit the entire patch set for above issue.

Regards,
Pramod

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] Add Shared MDIO framework for iProc based SoCs Pramod Kumar <pramod.kumar@broadcom.com> - 2016-04-21 11:20 +0200
  [PATCH 1/6] bus: Add shared MDIO bus framework Pramod Kumar <pramod.kumar@broadcom.com> - 2016-04-21 11:30 +0200
    Re: [PATCH 1/6] bus: Add shared MDIO bus framework David Miller <davem@davemloft.net> - 2016-04-24 20:20 +0200
      RE: [PATCH 1/6] bus: Add shared MDIO bus framework Pramod Kumar <pramod.kumar@broadcom.com> - 2016-04-25 06:20 +0200
    Re: [PATCH 1/6] bus: Add shared MDIO bus framework Andrew Lunn <andrew@lunn.ch> - 2016-04-25 23:00 +0200
      RE: [PATCH 1/6] bus: Add shared MDIO bus framework Pramod Kumar <pramod.kumar@broadcom.com> - 2016-04-26 10:40 +0200
        Re: [PATCH 1/6] bus: Add shared MDIO bus framework Andrew Lunn <andrew@lunn.ch> - 2016-04-26 14:20 +0200
          Re: [PATCH 1/6] bus: Add shared MDIO bus framework David Miller <davem@davemloft.net> - 2016-04-26 18:30 +0200
          Re: [PATCH 1/6] bus: Add shared MDIO bus framework Florian Fainelli <f.fainelli@gmail.com> - 2016-04-26 19:30 +0200
            Re: [PATCH 1/6] bus: Add shared MDIO bus framework Andrew Lunn <andrew@lunn.ch> - 2016-04-26 19:50 +0200
            Re: [PATCH 1/6] bus: Add shared MDIO bus framework Arnd Bergmann <arnd@arndb.de> - 2016-04-26 20:00 +0200
              Re: [PATCH 1/6] bus: Add shared MDIO bus framework Andrew Lunn <andrew@lunn.ch> - 2016-04-26 20:30 +0200
                Re: [PATCH 1/6] bus: Add shared MDIO bus framework Arnd Bergmann <arnd@arndb.de> - 2016-04-26 21:30 +0200
                Re: [PATCH 1/6] bus: Add shared MDIO bus framework Andrew Lunn <andrew@lunn.ch> - 2016-04-26 21:50 +0200
                Re: [PATCH 1/6] bus: Add shared MDIO bus framework Anup Patel <anup.patel@broadcom.com> - 2016-04-27 06:50 +0200
                Re: [PATCH 1/6] bus: Add shared MDIO bus framework Arnd Bergmann <arnd@arndb.de> - 2016-04-27 11:30 +0200
  [PATCH 6/6] net:phy: Add Ethernet Master for iProc Shared MDIO Controller Pramod Kumar <pramod.kumar@broadcom.com> - 2016-04-21 11:30 +0200
  [PATCH 5/6] Documentation: Binding doc for ethernet master in NS2 Pramod Kumar <pramod.kumar@broadcom.com> - 2016-04-21 11:30 +0200
    Re: [PATCH 5/6] Documentation: Binding doc for ethernet master in NS2 Rob Herring <robh@kernel.org> - 2016-04-22 22:20 +0200
      RE: [PATCH 5/6] Documentation: Binding doc for ethernet master in NS2 Pramod Kumar <pramod.kumar@broadcom.com> - 2016-04-25 06:50 +0200
  Re: [PATCH 0/6] Add Shared MDIO framework for iProc based SoCs Andrew Lunn <andrew@lunn.ch> - 2016-04-25 17:30 +0200

csiph-web