[PATCH 4/4] thermal: bang-bang governor: act on lower trip boundary

From	Caesar Wang <wxt@rock-chips.com>
Newsgroups	linux.kernel
Subject	[PATCH 4/4] thermal: bang-bang governor: act on lower trip boundary
Date	2016-04-25 05:10 +0200
Message-ID	<rrF4l-7bR-1@gated-at.bofh.it> (permalink)
References	<rrF4l-7bR-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Sascha Hauer <s.hauer@pengutronix.de>

With interrupt driven thermal zones we pass the lower and upper
temperature on which shall be acted, so in the governor we have to act on
the exact lower temperature to be consistent. Otherwise an interrupt maybe
generated on the exact lower temperature, but the bang bang governor does
not react.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm@vger.kernel.org

---

 drivers/thermal/gov_bang_bang.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c
index 70836c5..9d1dfea 100644
--- a/drivers/thermal/gov_bang_bang.c
+++ b/drivers/thermal/gov_bang_bang.c
@@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
 		if (instance->target == 0 && tz->temperature >= trip_temp)
 			instance->target = 1;
 		else if (instance->target == 1 &&
-				tz->temperature < trip_temp - trip_hyst)
+				tz->temperature <= trip_temp - trip_hyst)
 			instance->target = 0;
 
 		dev_dbg(&instance->cdev->device, "target=%d\n",
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] thermal: bang-bang governor: act on lower trip boundary Caesar Wang <wxt@rock-chips.com> - 2016-04-25 05:10 +0200
  Re: [PATCH 4/4] thermal: bang-bang governor: act on lower trip  boundary Eduardo Valentin <edubezval@gmail.com> - 2016-04-28 00:00 +0200
    Re: [PATCH 4/4] thermal: bang-bang governor: act on lower trip  boundary Sascha Hauer <s.hauer@pengutronix.de> - 2016-04-28 08:40 +0200

csiph-web