Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1385599
| Path | csiph.com!news.mixmin.net!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Julia Lawall <Julia.Lawall@lip6.fr> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] net: tsi108: use NULL for pointer-typed argument |
| Date | Sat, 23 Apr 2016 11:30:02 +0200 |
| Message-ID | <rr230-Ri-7@gated-at.bofh.it> (permalink) |
| X-Original-To | netdev@vger.kernel.org |
| X-Ironport-Av | E=Sophos;i="5.24,521,1454972400"; d="scan'208";a="215520392" |
| X-Mailer | git-send-email 1.9.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 34 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Sat, 23 Apr 2016 11:07:02 +0200 |
| X-Original-Message-ID | <1461402422-10879-1-git-send-email-Julia.Lawall@lip6.fr> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1385599 |
Show key headers only | View raw
The first argument of pci_free_consistent has type struct pci_dev *, so use
NULL instead of 0.
The semantic patch that performs this transformation is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
@@
pci_free_consistent(
- 0
+ NULL
, ...)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/tundra/tsi108_eth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -u -p a/drivers/net/ethernet/tundra/tsi108_eth.c b/drivers/net/ethernet/tundra/tsi108_eth.c
--- a/drivers/net/ethernet/tundra/tsi108_eth.c
+++ b/drivers/net/ethernet/tundra/tsi108_eth.c
@@ -1314,7 +1314,8 @@ static int tsi108_open(struct net_device
data->txring = dma_zalloc_coherent(NULL, txring_size, &data->txdma,
GFP_KERNEL);
if (!data->txring) {
- pci_free_consistent(0, rxring_size, data->rxring, data->rxdma);
+ pci_free_consistent(NULL, rxring_size, data->rxring,
+ data->rxdma);
return -ENOMEM;
}
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] net: tsi108: use NULL for pointer-typed argument Julia Lawall <Julia.Lawall@lip6.fr> - 2016-04-23 11:30 +0200 Re: [PATCH] net: tsi108: use NULL for pointer-typed argument David Miller <davem@davemloft.net> - 2016-04-26 07:20 +0200
csiph-web