Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning
Date	2016-04-23 09:30 +0200
Message-ID	<rr0aR-7Nb-1@gated-at.bofh.it> (permalink)
References	<rqGc9-hy-1@gated-at.bofh.it> <rqZya-7dw-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Apr 23, 2016 at 12:17:45PM +0530, Afzal Mohammed wrote:
> Hi,
> 
> On Fri, Apr 22, 2016 at 01:02:55PM +0300, Dan Carpenter wrote:
> 
> > -	int err, pipe, len, size, count, sent = 0;
> > +	int len = 0;
> > +	int err, pipe, size, count, sent = 0;
> 
> Is there any particular reason to avoid more than 1 variable
> initialization in definition on a single line ?, like,
> 
> 	int err, pipe, size, count, sent = 0, len = 0;
> 
> have observed that none of your uninitialized variable warning fixes
> does as mentioned above.

That sort of initialization is slightly less readable...

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] Bluetooth: ath3k: Silence uninitialized variable warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-22 12:10 +0200
  Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning Marcel Holtmann <marcel@holtmann.org> - 2016-04-22 12:50 +0200
  Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning Afzal Mohammed <afzal.mohd.ma@gmail.com> - 2016-04-23 08:50 +0200
    Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-23 09:30 +0200

csiph-web