Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings

From	Toshi Kani <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings
Date	2016-04-22 01:50 +0200
Message-ID	<rqwwa-IN-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <rpnXY-3a0-7@gated-at.bofh.it> <rpIzo-2JB-9@gated-at.bofh.it> <rqdjQ-27E-15@gated-at.bofh.it> <rqgUq-59Y-25@gated-at.bofh.it> <rqtoC-6Oc-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 4/21/2016 4:21 PM, Mike Kravetz wrote:
> On 04/21/2016 12:06 AM, Matthew Wilcox wrote:
>> On Wed, Apr 20, 2016 at 11:10:25PM -0400, Toshi Kani wrote:
>>> How about moving the function (as is) to mm/huge_memory.c, rename it to
>>> get_hugepage_unmapped_area(), which is defined to NULL in huge_mm.h
>>> when TRANSPARENT_HUGEPAGE is unset?
>> Great idea.  Perhaps it should look something like this?
>>
>> unsigned long thp_get_unmapped_area(struct file *filp, unsigned long addr,
>>                  unsigned long len, unsigned long pgoff, unsigned long flags)
>> {
> Might want to keep the future possibility of PUD_SIZE THP in mind?

Yes, this is why the func name does not say 'pmd'. It can be extended to 
support
PUD_SIZE in future.

Thanks,
-Toshi

Thread

Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Andrew Morton <akpm@linux-foundation.org> - 2016-04-16 07:10 +0200
  Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Jan Kara <jack@suse.cz> - 2016-04-18 22:30 +0200
    Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Matthew Wilcox <willy@linux.intel.com> - 2016-04-19 20:30 +0200
      Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-21 05:20 +0200
        Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Matthew Wilcox <willy@linux.intel.com> - 2016-04-21 09:10 +0200
          Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Mike Kravetz <mike.kravetz@oracle.com> - 2016-04-21 22:30 +0200
            Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-22 01:50 +0200
              Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Matthew Wilcox <willy@linux.intel.com> - 2016-04-22 02:30 +0200
                Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-22 03:00 +0200
          Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings Toshi Kani <toshi.kani@hpe.com> - 2016-04-22 01:40 +0200

csiph-web