Re: [PATCH] watchdog: core: Fix circular locking dependency

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] watchdog: core: Fix circular locking dependency
Date	2016-04-22 01:40 +0200
Message-ID	<rqwmt-Fk-5@gated-at.bofh.it> (permalink)
References	<rqnVT-29G-7@gated-at.bofh.it> <rqofg-2i1-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 21, 2016 at 03:50:55PM +0100, One Thousand Gnomes wrote:
> > Turns out the call to cancel_delayed_work_sync() in watchdog_release()
> > is not necessary and can be dropped. If the worker is no longer necessary,
> > the subsequent call to watchdog_update_worker() will cancel it. If it is
> > already running, it won't do anything, since the worker function checks
> > if it needs to ping the watchdog or not.
> 
> Is this actually true. Consider the pathalogical case of the device being
> closed and the modue unloaded. In that case the close completes, we drop
> the module count but could still do work on it.
> 
Module unload is handled separately and also calls cancel_delayed_work_sync().

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] watchdog: core: Fix circular locking dependency Guenter Roeck <linux@roeck-us.net> - 2016-04-21 16:40 +0200
  Re: [PATCH] watchdog: core: Fix circular locking dependency One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-04-21 17:00 +0200
    Re: [PATCH] watchdog: core: Fix circular locking dependency Guenter Roeck <linux@roeck-us.net> - 2016-04-22 01:40 +0200

csiph-web