Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for rk3399 SoCs

From	Brian Norris <briannorris@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for rk3399 SoCs
Date	2016-04-21 23:50 +0200
Message-ID	<rquE2-7GS-11@gated-at.bofh.it> (permalink)
References	<rpQQh-16h-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Wed, Apr 20, 2016 at 11:15:50AM +0800, Jianqun Xu wrote:
> This patch adds core dtsi file for rk3399 found on Rockchip
> rk3399 SoCs, tested on rk3399 evb.
> 
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1744 ++++++++++++++++++++++++++++++
>  1 file changed, 1744 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3399.dtsi
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> new file mode 100644
> index 0000000..fa6fc2c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -0,0 +1,1744 @@
[...]

> +	emmc_phy: phy {
> +		compatible = "rockchip,rk3399-emmc-phy";
> +		reg-offset = <0xf780>;

This property is not documented. The current doc says we "require" reg,
but you're kinda misusing it, I believe. At any rate, the current phy
driver won't probe without 'reg'.

> +		#phy-cells = <0>;
> +		rockchip,grf = <&grf>;
> +		status = "disabled";
> +	};

[...]

Brian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for rk3399 SoCs Brian Norris <briannorris@chromium.org> - 2016-04-21 23:50 +0200
  Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for rk3399 SoCs Heiko Stübner <heiko@sntech.de> - 2016-04-22 00:40 +0200

csiph-web