[PATCH] fs: fix over-zealous use of "const"

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH] fs: fix over-zealous use of "const"
Date	2016-04-21 22:00 +0200
Message-ID	<rqsVA-6gR-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

When I was fixing up const recommendations from checkpatch.pl, I went
overboard. This fixes the warning (during a W=1 build):

include/linux/fs.h:2627:74: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
static inline const char * const kernel_read_file_id_str(enum kernel_read_file_id id)

Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
This is for linux-security next
---
 include/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 518716b4834e..82f9a2db3b1a 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2610,7 +2610,7 @@ static const char * const kernel_read_file_str[] = {
 	__kernel_read_file_id(__fid_stringify)
 };
 
-static inline const char * const kernel_read_file_id_str(enum kernel_read_file_id id)
+static inline const char *kernel_read_file_id_str(enum kernel_read_file_id id)
 {
 	if (id < 0 || id >= READING_MAX_ID)
 		return kernel_read_file_str[READING_UNKNOWN];
-- 
2.6.3


-- 
Kees Cook
Chrome OS & Brillo Security

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] fs: fix over-zealous use of "const" Kees Cook <keescook@chromium.org> - 2016-04-21 22:00 +0200
  Re: [PATCH] fs: fix over-zealous use of "const" Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-22 00:20 +0200
  Re: [PATCH] fs: fix over-zealous use of "const" Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-25 11:10 +0200
  Re: [PATCH] fs: fix over-zealous use of "const" James Morris <jmorris@namei.org> - 2016-04-27 09:10 +0200

csiph-web