Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1384481

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

Show all headers | View raw

On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger <babu.moger@oracle.com> wrote:
> Current code writes the tx/rx relaxed order without reading it first.
> This can lead to unintended consequences as we are forcibly writing
> other bits.

The consequences were very much intended as there are situations where
enabling relaxed ordering can lead to data corruption.

> We noticed this problem while testing VF driver on sparc. Relaxed
> order settings for rx queue were all messed up which was causing
> performance drop with VF interface.

What additional relaxed ordering bits are you enabling on Sparc?  I'm
assuming it is just the Rx data write back but I want to verify.

> Fixed it by reading the registers first and setting the specific
> bit of interest. With this change we are able to match the bandwidth
> equivalent to PF interface.
>
> Signed-off-by: Babu Moger <babu.moger@oracle.com>

Fixed is a relative term here since you are only chasing performance
from what I can tell.  We need to make certain that this doesn't break
the driver on any other architectures by leading to things like data
corruption.

- Alex

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ixgbevf: Fix relaxed order settings in VF driver Babu Moger <babu.moger@oracle.com> - 2016-04-21 19:30 +0200
  Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver Alexander Duyck <alexander.duyck@gmail.com> - 2016-04-21 20:20 +0200
    Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver Alexander Duyck <alexander.duyck@gmail.com> - 2016-04-21 21:30 +0200
      Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver Babu Moger <babu.moger@oracle.com> - 2016-04-21 21:50 +0200
        Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver Alexander Duyck <alexander.duyck@gmail.com> - 2016-04-21 23:10 +0200

csiph-web