Re: [PATCH v2] regulator: core: Add debugfs to show constraint flags

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] regulator: core: Add debugfs to show constraint flags
Date	2016-04-21 17:10 +0200
Message-ID	<rqooW-2HE-13@gated-at.bofh.it> (permalink)
References	<rqm3M-Ju-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Apr 21, 2016 at 01:36:14PM +0100, Richard Fitzgerald wrote:

> +	ret = snprintf(buf, PAGE_SIZE,
> +		"always_on: %u\nboot_on: %u\napply_uV: %u\nramp_disable: %u\n"
> +		"soft_start: %u\npull_down: %u\nover_current_protection: %u\n",
> +		!!c->always_on,
> +		!!c->boot_on,
> +		!!c->apply_uV,
> +		!!c->ramp_disable,
> +		!!c->soft_start,
> +		!!c->pull_down,
> +		!!c->over_current_protection);

Can we try for legibility please?  Trying to cram everything onto the
minimum number of lines really doesn't help and the !!s either do
nothing or will end up obscuring information down the line.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] regulator: core: Add debugfs to show constraint flags Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2016-04-21 14:40 +0200
  Re: [PATCH v2] regulator: core: Add debugfs to show constraint flags Mark Brown <broonie@kernel.org> - 2016-04-21 17:10 +0200

csiph-web