Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1384256
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework |
| Date | 2016-04-21 16:00 +0200 |
| Message-ID | <rqnjd-1xU-29@gated-at.bofh.it> (permalink) |
| References | <rmLWN-81T-3@gated-at.bofh.it> <rmM6v-87k-45@gated-at.bofh.it> <rq80P-6j3-17@gated-at.bofh.it> <rqnjd-1xU-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
> I assumed this check was bogus and there are no valid 0-length > messages... They are valid (check SMBUS_QUICK), but not every controller can handle them correctly. Your driver has SMBUS_QUICK enabled, so this is a contradiction to the check above where it rejects it. So, it looks like it needs to be tested again (and documented this time). If the HW can't do it, the FUNC bit for QUICK needs to be masked out. If it can do SMBUS_QUICK, the check can probably go away.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework Wolfram Sang <wsa@the-dreams.de> - 2016-04-20 23:40 +0200
Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework Wolfram Sang <wsa@the-dreams.de> - 2016-04-21 16:00 +0200
Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework Jan Glauber <jan.glauber@caviumnetworks.com> - 2016-04-21 20:00 +0200
Re: [PATCH v6 07/19] i2c: octeon: Use i2c recovery framework Wolfram Sang <wsa@the-dreams.de> - 2016-04-21 23:40 +0200
csiph-web