Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1384167

Re: [PATCH] x86/efi: Remove the always true EFI_DEBUG symbol

Show all headers | View raw

On Thu, 21 Apr, at 02:45:42PM, Borislav Petkov wrote:
> On Thu, Apr 21, 2016 at 12:09:30PM +0100, Matt Fleming wrote:
> > This symbol is always set which makes it useless. Additionally we have
> > a kernel command-line switch, efi=debug, which actually controls the
> > printing of the memory map.
> > 
> > Reported-by: Robert Elliott <elliott@hpe.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
> > ---
> >  arch/x86/platform/efi/efi.c | 4 ----
> >  1 file changed, 4 deletions(-)
> 
> Acked-by: Borislav Petkov <bp@suse.de>
> 
> Btw, there's also
> 
> arch/ia64/kernel/efi.c:45:#define EFI_DEBUG     0
> arch/ia64/kernel/efi.c:399:#if EFI_DEBUG
> arch/ia64/kernel/efi.c:559:#if EFI_DEBUG
> 
> I'm assuming you want to put that behind "if (efi_enabled(EFI_DBG))" too...

Hmm.. Yes, that'd be a good idea. I am in the process of setting up an
Itanium box or two for runtime EFI testing, so I'll make a note of
this task.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/efi: Remove the always true EFI_DEBUG symbol Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-21 13:10 +0200
  Re: [PATCH] x86/efi: Remove the always true EFI_DEBUG symbol Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-21 14:50 +0200
  Re: [PATCH] x86/efi: Remove the always true EFI_DEBUG symbol Borislav Petkov <bp@alien8.de> - 2016-04-21 14:50 +0200

csiph-web