Re: [PATCH v3 02/19] clk: sunxi: Add display and TCON0 clocks driver

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 02/19] clk: sunxi: Add display and TCON0 clocks driver
Date	2016-04-21 14:10 +0200
Message-ID	<rqlAK-vr-17@gated-at.bofh.it> (permalink)
References	<rfTZ8-69G-21@gated-at.bofh.it> <rfU8O-6dp-9@gated-at.bofh.it> <rokz9-1OV-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Stephen,

On Fri, Apr 15, 2016 at 03:34:10PM -0700, Stephen Boyd wrote:
> > +static int sun4i_a10_display_reset_xlate(struct reset_controller_dev *rcdev,
> > +					 const struct of_phandle_args *spec)
> > +{
> > +	/* We only have a single reset signal */
> > +	return 0;
> > +}
> 
> Is there a default function for this case in the reset framework?

No, the reset bindings assumes that you have a cell size of 1, and
it's the only case that's supported by the reset framework default
xlate.

I adressed the rest of your comments.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 02/19] clk: sunxi: Add display and TCON0 clocks driver Stephen Boyd <sboyd@codeaurora.org> - 2016-04-16 00:40 +0200
  Re: [PATCH v3 02/19] clk: sunxi: Add display and TCON0 clocks driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-04-21 14:10 +0200

csiph-web