Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1384077
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] i2c: designware-platdrv: fix unbalanced clk enable and prepare |
| Date | 2016-04-21 13:10 +0200 |
| Message-ID | <rqkEI-8dU-69@gated-at.bofh.it> (permalink) |
| References | <rqjfA-70c-19@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Thu, 2016-04-21 at 17:26 +0800, Jisheng Zhang wrote: > If i2c_dw_probe() fail, we should disable and unprepare the clk, clk -> clock, or use function name explicitly. > otherwise the clk enable and prepare is left unbalanced. > Ditto. > In dw_i2c_plat_remove(), we'd better to not rely on rpm to disable > and unprepare the clk since CONFIG_PM may be disabled when configuring Ditto. > the kernel. So we explicitly disable and unprepare the clk in Ditto. > dw_i2c_plat_remove(). > + pm_runtime_put_noidle(&pdev->dev); > > - pm_runtime_put_sync(&pdev->dev); > This change also needs to be described in the commit message. -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2] i2c: designware-platdrv: fix unbalanced clk enable and prepare Jisheng Zhang <jszhang@marvell.com> - 2016-04-21 11:40 +0200 Re: [PATCH v2] i2c: designware-platdrv: fix unbalanced clk enable and prepare Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-04-21 13:10 +0200
csiph-web