Re: [PATCH V2 07/14] genirq: Add runtime power management support for IRQ chips

From	Jon Hunter <jonathanh@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 07/14] genirq: Add runtime power management support for IRQ chips
Date	2016-04-21 11:20 +0200
Message-ID	<rqiWe-6OB-3@gated-at.bofh.it> (permalink)
References	<rpYb8-6WM-7@gated-at.bofh.it> <rpYb8-6WM-9@gated-at.bofh.it> <rq3Xc-2Z1-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20/04/16 18:11, Kevin Hilman wrote:
> Jon Hunter <jonathanh@nvidia.com> writes:
> 
>> Some IRQ chips may be located in a power domain outside of the CPU
>> subsystem and hence will require device specific runtime power
>> management. In order to support such IRQ chips, add a pointer for a
>> device structure to the irq_chip structure, and if this pointer is
>> populated by the IRQ chip driver and CONFIG_PM is selected in the kernel
>> configuration, then the pm_runtime_get/put APIs for this chip will be
>> called when an IRQ is requested/freed, respectively.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> 
> [...]
> 
>> @@ -1891,10 +1906,18 @@ int setup_percpu_irq(unsigned int irq, struct irqaction *act)
>>  
>>  	if (!desc || !irq_settings_is_per_cpu_devid(desc))
>>  		return -EINVAL;
>> +
>> +	retval = irq_chip_pm_get(&desc->irq_data);
>> +	if (retval < 0)
>> +		return retval;
>> +
>>  	chip_bus_lock(desc);
>>  	retval = __setup_irq(irq, desc, act);
>>  	chip_bus_sync_unlock(desc);
>>  
>> +	if (retval)
>> +		irq_chip_pm_get(&desc->irq_data);
>> +
> 
> Shouldn't this one be a _put() ?

Good grief! Yes it should. Sorry, will fix :-(

> Otherwise, LGTM
> 
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>

Thanks!
Jon

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 07/14] genirq: Add runtime power management support for IRQ chips Jon Hunter <jonathanh@nvidia.com> - 2016-04-20 13:10 +0200
  Re: [PATCH V2 07/14] genirq: Add runtime power management support for IRQ chips Kevin Hilman <khilman@baylibre.com> - 2016-04-20 19:20 +0200
    Re: [PATCH V2 07/14] genirq: Add runtime power management support for  IRQ chips Jon Hunter <jonathanh@nvidia.com> - 2016-04-21 11:20 +0200

csiph-web