Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383905

Re: [PATCH] drm/vc4: Add missing render node support

Show all headers | View raw

On Wed, Apr 20, 2016 at 03:20:49PM -0700, Eric Anholt wrote:
> There shouldn't be any other driver support necessary, since none of
> the driver-specific ioctls ever required auth, and none of them deal
> with modesetting.

Indeed, somehow I thought you need to mark them all up explicitly. But
that's only the case for DRM_AUTH ioctls.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Aside: I wonder whether we should go through all the drivers and replace
DRM_AUTH | DRM_RENDER_ALLOW with 0? It looks a bit like drm ioctl flags
are cargo culted ...
-Daniel

> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  drivers/gpu/drm/vc4/vc4_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 54f9f52fa004..143dd98aa079 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -81,6 +81,7 @@ static struct drm_driver vc4_drm_driver = {
>  			    DRIVER_ATOMIC |
>  			    DRIVER_GEM |
>  			    DRIVER_HAVE_IRQ |
> +			    DRIVER_RENDER |
>  			    DRIVER_PRIME),
>  	.lastclose = vc4_lastclose,
>  	.irq_handler = vc4_irq,
> -- 
> 2.8.0.rc3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/vc4: Add missing render node support Eric Anholt <eric@anholt.net> - 2016-04-21 00:30 +0200
  Re: [PATCH] drm/vc4: Add missing render node support Daniel Vetter <daniel@ffwll.ch> - 2016-04-21 09:30 +0200

csiph-web