Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383820

Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip points

Show all headers | View raw

+ Sascha

On Wed, Apr 20, 2016 at 04:48:18PM -0700, Eduardo Valentin wrote:
> On Mon, Apr 18, 2016 at 11:35:59AM +0800, Caesar Wang wrote:
> > From: Mikko Perttunen <mperttunen@nvidia.com>
> > 
> > This adds support for hardware-tracked trip points to the device tree
> <cut>
> 
> > diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> > index 97b86c5..6ef932a 100644
> > --- a/include/linux/thermal.h
> > +++ b/include/linux/thermal.h
> > @@ -335,12 +335,14 @@ struct thermal_genl_event {
> >   * @get_trend: a pointer to a function that reads the sensor temperature trend.
> >   * @set_emul_temp: a pointer to a function that sets sensor emulated
> >   *		   temperature.
> > + * @set_trips: a pointer to a function that set low/high trip temperature.
> >   */
> >  struct thermal_zone_of_device_ops {
> >  	int (*get_temp)(void *, int *);
> >  	int (*get_trend)(void *, long *);
> >  	int (*set_emul_temp)(void *, int);
> >  	int (*set_trip_temp)(void *, int, int);
> > +	int (*set_trips)(void *, int, int);
> 
> This is unfortunately a diverges from API available on thermal core. Can
> you please add first on thermal core then, use it in of thermal?
> 
> I don't want to have callbacks available only via of thermal. If we
> allow it, OF thermal becomes a separate API.

What ever happened to this effort?

http://thread.gmane.org/gmane.linux.power-management.general/59451

Patch 12 and 13 look to accomplish something similar, yet they do what
Eduardo suggested. I was testing that series at my previous job, but
unfortunately (for the fate of this series) I left that employer before
I could finish reviewing and testing it. Perhaps Caesar can resurrect
and test it?

Brian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] thermal: rockchip: Support rk3366/rk3399 SoCS and fixes the driver Caesar Wang <wxt@rock-chips.com> - 2016-04-18 05:40 +0200
  [PATCH 1/9] thermal: rockchip: disable thermal->clk in err case Caesar Wang <wxt@rock-chips.com> - 2016-04-18 05:40 +0200
  [PATCH 7/9] thermal: of: Add support for hardware-tracked trip points Caesar Wang <wxt@rock-chips.com> - 2016-04-18 05:40 +0200
    Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip  points Eduardo Valentin <edubezval@gmail.com> - 2016-04-21 01:50 +0200
      Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip  points Brian Norris <briannorris@chromium.org> - 2016-04-21 03:20 +0200
        Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip  points Caesar Wang <caesar.upstream@gmail.com> - 2016-04-22 04:00 +0200
          Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip  points Sascha Hauer <s.hauer@pengutronix.de> - 2016-04-22 07:50 +0200
            Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip  points Caesar Wang <caesar.upstream@gmail.com> - 2016-04-22 12:20 +0200
              Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip  points Eduardo Valentin <edubezval@gmail.com> - 2016-04-28 00:00 +0200
  [PATCH 3/9] thermal: rockchip: update the tsadc table for rk3399 Caesar Wang <wxt@rock-chips.com> - 2016-04-18 05:40 +0200
  [PATCH 8/9] thermal: rockchip: add the set_trips function Caesar Wang <wxt@rock-chips.com> - 2016-04-18 05:40 +0200
  Re: [PATCH 0/9] thermal: rockchip: Support rk3366/rk3399 SoCS and  fixes the driver Eduardo Valentin <edubezval@gmail.com> - 2016-04-28 02:00 +0200

csiph-web