Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383799

Re: [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor driver

Show all headers | View raw

Laxman,

On Tue, Apr 19, 2016 at 12:52:01PM +0530, Laxman Dewangan wrote:
> In some of platform, thermal sensors like NCT thermistors are
> connected to the one of ADC channel. The temperature is read by
> reading the voltage across the sensor resistance via ADC. Lookup
> table for ADC read value to temperature is referred to get
> temperature. ADC is read via IIO framework.
> 
> Add support for thermal sensor driver which read the voltage across
> sensor resistance from ADC through IIO framework.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

I really like this driver, as I mentioned  before. Just one comment
though.

> 
> +
> +	gti->tz_dev = thermal_zone_of_sensor_register(&pdev->dev, 0,
> +						      gti, &gadc_thermal_ops);

Why not using the devm_ version you introduced?

Any particular reason?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V4 1/2] thermal: generic-adc: Add DT binding for ADC based thermal sensor Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-19 09:40 +0200
  [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-19 09:40 +0200
    Re: [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor  driver Jonathan Cameron <jic23@kernel.org> - 2016-04-19 21:10 +0200
    Re: [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal  sensor driver Eduardo Valentin <edubezval@gmail.com> - 2016-04-21 01:50 +0200
      Re: [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor  driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-21 03:30 +0200
        Re: [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal  sensor driver Eduardo Valentin <edubezval@gmail.com> - 2016-04-21 05:00 +0200

csiph-web