Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support
Date	2016-04-22 19:40 +0200
Message-ID	<rqNdE-5NN-23@gated-at.bofh.it> (permalink)
References	(2 earlier) <rqrZv-5rZ-9@gated-at.bofh.it> <rqEDo-7qZ-7@gated-at.bofh.it> <rqK65-3fM-9@gated-at.bofh.it> <rqMKB-5xq-19@gated-at.bofh.it> <rqN3Y-5It-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 22, 2016 at 7:28 PM, Noralf Trønnes <noralf@tronnes.org> wrote:
> This patch extend the use of the fbdev deferred_io worker to also handle
> the fbdev drawing operations, which can happen in atomic context.
> The qxl driver adds an extra worker (struct qxl_device).fb_work which is
> used to flush the framebuffer. Both the mmap deferred_io (qxl_deferred_io())
> code which is run by the deferred io worker and the fbdev drawing operations
> (qxl_fb_fillrect() etc.) schedule this fb_work worker.
>
> So this patch uses 1 worker, qxl uses 2 workers.

Oh, I didn't realize that you're reusing the same worker for both
things. 2 workers indeed make sense, since the mmap one must have a
built-in delay (to coalesce a bunch of writes), whereas the other one
probably should be run right away, after each op.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes <noralf@tronnes.org> - 2016-04-20 17:40 +0200
  Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support kbuild test robot <lkp@intel.com> - 2016-04-20 18:50 +0200
  Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes <noralf@tronnes.org> - 2016-04-21 21:00 +0200
    Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Daniel Vetter <daniel@ffwll.ch> - 2016-04-22 10:30 +0200
      Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes <noralf@tronnes.org> - 2016-04-22 16:20 +0200
        Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Daniel Vetter <daniel@ffwll.ch> - 2016-04-22 19:10 +0200
          Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes <noralf@tronnes.org> - 2016-04-22 19:30 +0200
            Re: [PATCH 4/8] drm/fb-helper: Add fb_deferred_io support Daniel Vetter <daniel@ffwll.ch> - 2016-04-22 19:40 +0200

csiph-web