Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1385232

Re: [PATCH v3] dmaengine: tegra-apb: proper default init of channel slave_id

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Apr 22, 2016 at 07:44:39PM +0530, Shardar Shariff Md wrote:
> Initialize default channel slave_id(req_sel) to invalid id
> (i.e max supported slave id + 1) to avoid overwriting of slave_id
> during tegra_dma_slave_config() with client data if slave_id
> is not initialized through DT
> 
> Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>
> 
> ---
> Changes from v1:
> - Instead of initializing the slave id to -1 define macros for
>   max slave id and invalid slave id and do the checks accordingly.
> 
> Changes from v2:
> - Check slave id boundary before dma channel is allocated to
>   avoid channel leakage.
> ---
>  drivers/dma/tegra20-apb-dma.c | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)

Looks good to me, though I'm not a DMA engine export, so I'll only
offer:

Acked-by: Thierry Reding <treding@nvidia.com>

Perhaps Jon would be comfortable enough to give a Reviewed-by?

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] dmaengine: tegra-apb: proper default init of channel slave_id Shardar Shariff Md <smohammed@nvidia.com> - 2016-04-22 16:20 +0200
  Re: [PATCH v3] dmaengine: tegra-apb: proper default init of channel  slave_id Thierry Reding <thierry.reding@gmail.com> - 2016-04-22 16:40 +0200
  Re: [PATCH v3] dmaengine: tegra-apb: proper default init of channel  slave_id Jon Hunter <jonathanh@nvidia.com> - 2016-04-22 16:50 +0200

csiph-web