[PATCH v2 3/3] checkpatch: relax Kconfig help text line number threshold

From	Yingjoe Chen <yingjoe.chen@mediatek.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 3/3] checkpatch: relax Kconfig help text line number threshold
Date	2016-04-22 16:40 +0200
Message-ID	<rqKps-3oW-23@gated-at.bofh.it> (permalink)
References	<rqKpr-3oW-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Current threshold is too strict and many upstream patch doesn't pass
this test. Relax it.

Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>

---
In v4.6-rc1, 171 new config options was added, and 87 of those options
have < 4 lines and 24 options have only 1 line. After this change,
checkpatch only raise warning when help text only contain 1 line.

Some options try to workaround this check by adding 2 lines
template like 'If you have this device...' which doesn't add value.

---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 403ebbc..4bfb23b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -47,7 +47,7 @@ my $configuration_file = ".checkpatch.conf";
 my $max_line_length = 80;
 my $ignore_perl_version = 0;
 my $minimum_perl_version = 5.10.0;
-my $min_conf_desc_length = 4;
+my $min_conf_desc_length = 2;
 my $spelling_file = "$D/spelling.txt";
 my $codespell = 0;
 my $codespellfile = "/usr/share/codespell/dictionary.txt";
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] checkpatch: add Kconfig 'default n' test Yingjoe Chen <yingjoe.chen@mediatek.com> - 2016-04-22 16:40 +0200
  [PATCH v2 3/3] checkpatch: relax Kconfig help text line number threshold Yingjoe Chen <yingjoe.chen@mediatek.com> - 2016-04-22 16:40 +0200

csiph-web