Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1385263
| From | One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] PM / OPP: -ENOSYS is applicable only to syscalls |
| Date | 2016-04-22 17:10 +0200 |
| Message-ID | <rqKSu-3S9-21@gated-at.bofh.it> (permalink) |
| References | <rqiCR-6mQ-5@gated-at.bofh.it> <rqzNn-3nA-5@gated-at.bofh.it> <rqIxk-1Ux-9@gated-at.bofh.it> |
| Organization | Intel Corporation |
On Fri, 22 Apr 2016 14:42:31 +0200 "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote: > On Friday, April 22, 2016 08:46:51 AM Viresh Kumar wrote: > > Some of the routines have use -ENOSYS, which is supposed to be used only > > for syscalls. Replace that with -EINVAL. > > -EINVAL specifically means "invalid argument". > > What about using -ENXIO instead? That specifically means "device not present", but might be reasonable. Quite a bit of the kernel uses EOPNOTSUPP (operation not supported). Before you change it though please check how existing userspace does error handling. It's nice to use more "correct" error codes, but that's not sufficient reason if it turns out that existing user space checks for ENOSYS for example. Alan
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] PM / OPP: -ENOSYS is applicable only to syscalls Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-22 05:20 +0200
Re: [PATCH] PM / OPP: -ENOSYS is applicable only to syscalls "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-04-22 14:40 +0200
Re: [PATCH] PM / OPP: -ENOSYS is applicable only to syscalls One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-04-22 17:10 +0200
Re: [PATCH] PM / OPP: -ENOSYS is applicable only to syscalls Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-27 04:50 +0200
csiph-web