Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1385055

Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

Show all headers | View raw

On 04/22/2016 12:43 PM, Jim Lin wrote:
> Android N adds os_desc_compat in v2_descriptor by init_functionfs()
> (system/core/adb/usb_linux_client.cpp) to support automatic install
> of MTP driver on Windows for USB device mode.
> 
> Current __ffs_data_do_os_desc() of f_fs.c will check reserved1 field
> and return -EINVAL.
> This results in a second adb_write of usb_linux_client.cpp
> (system/core/adb/) which doesn't have ss_descriptors filled.
> Then later kernel_panic (composite.c) occurs when ss_descriptors
> as a pointer with NULL is being accessed.
> 
> Fix is to ignore the checking on reserved1 field so that first
> adb_write goes successfully with v2_descriptor which has
> ss_descriptors filled.

That sounds like the wrong approach. The kernel should not crash if
ss_descriptors is not filled. I think the right fix is to make sure that the
NULL pointer deref can never happen regardless of which input is supplied by
userspace.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed Jim Lin <jilin@nvidia.com> - 2016-04-22 12:50 +0200
  Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed Lars-Peter Clausen <lars@metafoo.de> - 2016-04-22 13:30 +0200
  Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed Felipe Balbi <balbi@kernel.org> - 2016-04-22 14:00 +0200
    Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed Jim Lin <jilin@nvidia.com> - 2016-04-25 13:40 +0200
      Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed Felipe Balbi <balbi@kernel.org> - 2016-04-25 14:10 +0200
        Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed Jim Lin <jilin@nvidia.com> - 2016-04-26 11:00 +0200

csiph-web