Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1384914

Re: [patch] spi: pic32-sqi: silence array overflow warning

Show all headers | View raw

On 04/22/2016 03:25 PM, Dan Carpenter wrote:

> We read one element beyond the end of the array when we access
> "rdesc[i + 1]" so it causes a static checker warning.  It's harmless
> because we write over it again on the next line.  But let's just silence
> the warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/spi/spi-pic32-sqi.c b/drivers/spi/spi-pic32-sqi.c
> index b215347..74b9e68 100644
> --- a/drivers/spi/spi-pic32-sqi.c
> +++ b/drivers/spi/spi-pic32-sqi.c
> @@ -537,7 +537,7 @@ static int ring_desc_ring_alloc(struct pic32_sqi *sqi)
>  	}
>  
>  	/* Prepare BD: chain to next BD(s) */
> -	for (i = 0, rdesc = sqi->ring; i < PESQI_BD_COUNT; i++)
> +	for (i = 0, rdesc = sqi->ring; i < PESQI_BD_COUNT - 1; i++)
>  		bd[i].bd_nextp = rdesc[i + 1].bd_dma;
>  	bd[PESQI_BD_COUNT - 1].bd_nextp = 0;
>
Reviewed-by: Purna Chandra Mandal <purna.mandal@microchip.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] spi: pic32-sqi: silence array overflow warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-22 12:00 +0200
  Re: [patch] spi: pic32-sqi: silence array overflow warning Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-04-22 12:10 +0200
  Applied "spi: pic32-sqi: silence array overflow warning" to the spi tree Mark Brown <broonie@kernel.org> - 2016-04-22 17:30 +0200

csiph-web