[patch] iio: light: apds9960: silence uninitialized variable warning

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] iio: light: apds9960: silence uninitialized variable warning
Date	2016-04-22 12:10 +0200
Message-ID	<rqGca-hy-19@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

It causes a static checker warning if we use "buf" on the failure path
so move that inside the if statement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index a6af56a..fbdd172 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -491,9 +491,10 @@ static int apds9960_read_raw(struct iio_dev *indio_dev,
 		case IIO_INTENSITY:
 			ret = regmap_bulk_read(data->regmap, chan->address,
 					       &buf, 2);
-			if (!ret)
+			if (!ret) {
 				ret = IIO_VAL_INT;
-			*val = le16_to_cpu(buf);
+				*val = le16_to_cpu(buf);
+			}
 			break;
 		default:
 			ret = -EINVAL;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] iio: light: apds9960: silence uninitialized variable warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-22 12:10 +0200
  Re: [patch] iio: light: apds9960: silence uninitialized variable  warning Jonathan Cameron <jic23@kernel.org> - 2016-04-23 23:20 +0200

csiph-web