Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1384831

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

Show all headers | View raw

On Thu, Apr 21, 2016 at 03:56:07PM -0700, Shi, Yang wrote:
> On 4/21/2016 12:30 AM, Kirill A. Shutemov wrote:
> >On Wed, Apr 20, 2016 at 02:00:11PM -0700, Shi, Yang wrote:
> >>Hi folks,
> >>
> >>I didn't realize pmd_* functions are protected by
> >>CONFIG_TRANSPARENT_HUGEPAGE on the most architectures before I made this
> >>change.
> >>
> >>Before I fix all the affected architectures code, I want to check if you
> >>guys think this change is worth or not?
> >>
> >>Thanks,
> >>Yang
> >>
> >>On 4/20/2016 11:24 AM, Yang Shi wrote:
> >>>huge_pmd_set_accessed is only called by __handle_mm_fault from memory.c,
> >>>move the definition to memory.c and make it static like create_huge_pmd and
> >>>wp_huge_pmd.
> >>>
> >>>Signed-off-by: Yang Shi <yang.shi@linaro.org>
> >
> >On pte side we have the same functionality open-coded. Should we do the
> >same for pmd? Or change pte side the same way?
> 
> Sorry, I don't quite understand you. Do you mean pte_* functions?

See handle_pte_fault(), we do the same for pte there what
huge_pmd_set_accessed() does for pmd.

I think we should be consistent here: either both are abstructed into
functions or both open-coded.

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c Yang Shi <yang.shi@linaro.org> - 2016-04-20 21:00 +0200
  Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c kbuild test robot <lkp@intel.com> - 2016-04-20 21:30 +0200
  Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c "Shi, Yang" <yang.shi@linaro.org> - 2016-04-20 23:10 +0200
    Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-04-21 09:40 +0200
      Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c "Shi, Yang" <yang.shi@linaro.org> - 2016-04-22 01:00 +0200
        Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-04-22 11:50 +0200
    Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c Hugh Dickins <hughd@google.com> - 2016-04-21 11:20 +0200
      Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c "Shi, Yang" <yang.shi@linaro.org> - 2016-04-22 01:00 +0200

csiph-web