Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1384783
| From | changbin.du@intel.com |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/7] debugobjects: correct the usage of fixup call results |
| Date | 2016-04-22 10:30 +0200 |
| Message-ID | <rqEDp-7qZ-27@gated-at.bofh.it> (permalink) |
| References | <rqEtI-7kx-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: "Du, Changbin" <changbin.du@intel.com> If debug_object_fixup() return non-zero when problem has been fixed. But the code got it backwards, it taks 0 as fixup successfully. So fix it. Signed-off-by: Du, Changbin <changbin.du@intel.com> --- lib/debugobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/debugobjects.c b/lib/debugobjects.c index a9cee16..2f07c8c 100644 --- a/lib/debugobjects.c +++ b/lib/debugobjects.c @@ -415,7 +415,7 @@ int debug_object_activate(void *addr, struct debug_obj_descr *descr) state = obj->state; raw_spin_unlock_irqrestore(&db->lock, flags); ret = debug_object_fixup(descr->fixup_activate, addr, state); - return ret ? -EINVAL : 0; + return ret ? 0 : -EINVAL; case ODEBUG_STATE_DESTROYED: debug_print_object(obj, "activate"); -- 2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] Make debugobjects fixup functions return bool type changbin.du@intel.com - 2016-04-22 10:20 +0200
[PATCH 3/7] workqueue: update debugobjects fixup callbacks return type changbin.du@intel.com - 2016-04-22 10:30 +0200
[PATCH 5/7] rcu: update debugobjects fixup callbacks return type changbin.du@intel.com - 2016-04-22 10:30 +0200
[PATCH 6/7] percpu_counter: update debugobjects fixup callbacks return type changbin.du@intel.com - 2016-04-22 10:30 +0200
[PATCH 2/7] debugobjects: correct the usage of fixup call results changbin.du@intel.com - 2016-04-22 10:30 +0200
Re: [PATCH 2/7] debugobjects: correct the usage of fixup call results Thomas Gleixner <tglx@linutronix.de> - 2016-04-22 11:10 +0200
[PATCH 7/7] Documentation: update debugobjects doc changbin.du@intel.com - 2016-04-22 10:30 +0200
csiph-web