Re: [PATCH 5/8] cpufreq: shmobile: Use generic platdev driver

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/8] cpufreq: shmobile: Use generic platdev driver
Date	2016-04-22 08:50 +0200
Message-ID	<rqD4B-65u-3@gated-at.bofh.it> (permalink)
References	<rqitb-6j1-9@gated-at.bofh.it> <rqitc-6j1-27@gated-at.bofh.it> <rqmwO-1cP-23@gated-at.bofh.it> <rqzX3-3rj-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Viresh,

On Fri, Apr 22, 2016 at 5:21 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 21-04-16, 15:04, Geert Uytterhoeven wrote:
>> On Thu, Apr 21, 2016 at 10:43 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> > @@ -29,6 +29,18 @@ static const struct of_device_id machines[] = {
>> >         { .compatible = "samsung,exynos5800", },
>> >  #endif
>> >
>>
>> I think an #ifdef CONFIG_ARCH_RENESAS block wouldn't hurt, likewise
>> for the other SoCs.
>> Soon you'll have this file filled with lots of compatible values for random\
>> SoCs...
>
> This is going to be done once per boot and this shouldn't hurt. And for new
> platforms we may do things differently as they are going to use opp-v2 bindings.

I was mainly thinking about kernel size.
If this is done once per boot, the array should be __initconst,
(looking at the code
in next) which is fine as cpufreq_dt_platdev_init() is already __init.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Thread

[PATCH 5/8] cpufreq: shmobile: Use generic platdev driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-21 10:50 +0200
  Re: [PATCH 5/8] cpufreq: shmobile: Use generic platdev driver Geert Uytterhoeven <geert@linux-m68k.org> - 2016-04-21 15:10 +0200
    Re: [PATCH 5/8] cpufreq: shmobile: Use generic platdev driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-22 05:30 +0200
      Re: [PATCH 5/8] cpufreq: shmobile: Use generic platdev driver Geert Uytterhoeven <geert@linux-m68k.org> - 2016-04-22 08:50 +0200
        Re: [PATCH 5/8] cpufreq: shmobile: Use generic platdev driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-22 08:50 +0200

csiph-web