[PATCH] usb: core: Do not use sizeof on pointer type

From	Vaishali Thakkar <vaishali.thakkar@oracle.com>
Newsgroups	linux.kernel
Subject	[PATCH] usb: core: Do not use sizeof on pointer type
Date	2016-04-22 08:00 +0200
Message-ID	<rqCie-5m3-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

When sizeof is applied to a pointer typed expression, it gives
the size of the pointer. So, do not use sizeof on pointer type.

Problem found using Coccinelle.

Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
---
 drivers/usb/core/hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 2ca2cef..2aa352d 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1386,7 +1386,7 @@ static int hcd_alloc_coherent(struct usb_bus *bus,
 		return -EFAULT;
 	}
 
-	vaddr = hcd_buffer_alloc(bus, size + sizeof(vaddr),
+	vaddr = hcd_buffer_alloc(bus, size + sizeof(*vaddr),
 				 mem_flags, dma_handle);
 	if (!vaddr)
 		return -ENOMEM;
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: core: Do not use sizeof on pointer type Vaishali Thakkar <vaishali.thakkar@oracle.com> - 2016-04-22 08:00 +0200
  Re: [PATCH] usb: core: Do not use sizeof on pointer type Bjørn Mork <bjorn@mork.no> - 2016-04-22 09:00 +0200
  Re: [PATCH] usb: core: Do not use sizeof on pointer type Clemens Ladisch <clemens@ladisch.de> - 2016-04-22 09:00 +0200

csiph-web