Re: platform/chrome: cros_ec_dev - Populate compat_ioctl

From	Brian Norris <briannorris@chromium.org>
Newsgroups	linux.kernel
Subject	Re: platform/chrome: cros_ec_dev - Populate compat_ioctl
Date	2016-04-20 23:50 +0200
Message-ID	<rq8av-6mN-5@gated-at.bofh.it> (permalink)
References	<ro1PP-3XY-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 14, 2016 at 07:35:29PM -0700, Guenter Roeck wrote:
> compat_ioctl has to be populated for 32 bit userspace applications to work
> with 64 bit kernels.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Tested with 32-bit user space on ARM64:

Tested-by: Brian Norris <briannorris@chromium.org>

> ---
> drivers/platform/chrome/cros_ec_dev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
> index 6c45e0f5ba7b..903b1d8dcab7 100644
> --- a/drivers/platform/chrome/cros_ec_dev.c
> +++ b/drivers/platform/chrome/cros_ec_dev.c
> @@ -208,6 +208,9 @@ static const struct file_operations fops = {
>  	.release = ec_device_release,
>  	.read = ec_device_read,
>  	.unlocked_ioctl = ec_device_ioctl,
> +#ifdef CONFIG_COMPAT
> +	.compat_ioctl = ec_device_ioctl,
> +#endif
>  };
>  
>  static void __remove(struct device *dev)

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: platform/chrome: cros_ec_dev - Populate compat_ioctl Brian Norris <briannorris@chromium.org> - 2016-04-20 23:50 +0200

csiph-web