Re: [PATCH v3 1/2] ext4: Pass in DIO_SKIP_DIO_COUNT flag if inode_dio_begin() called

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] ext4: Pass in DIO_SKIP_DIO_COUNT flag if inode_dio_begin() called
Date	Wed, 20 Apr 2016 23:00:03 +0200
Message-ID	<rq7o7-5F5-27@gated-at.bofh.it> (permalink)
References	<rnb4R-3n3-11@gated-at.bofh.it> <rnb4R-3n3-9@gated-at.bofh.it>
X-Original-To	Waiman Long <Waiman.Long@hpe.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
X-Srs-Rewrite	SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	4
Organization	linux.* mail to news gateway
X-Original-Cc	Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>, Scott J Norton <scott.norton@hpe.com>, Douglas Hatch <doug.hatch@hpe.com>, Toshimitsu Kani <toshi.kani@hpe.com>
X-Original-Date	Wed, 20 Apr 2016 13:58:01 -0700
X-Original-Message-ID	<20160420205801.GA24609@infradead.org>
X-Original-References	<1460484775-33359-1-git-send-email-Waiman.Long@hpe.com> <1460484775-33359-2-git-send-email-Waiman.Long@hpe.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1383742

Show key headers only | View raw

FYI, none of the Dax code even needs to ever touch the dio_count,
as dax I/O can't be asynchronous, and we thus don't need it to protect
against truncate.  I'd suggest to remove it and then end_io callback
from the DAX code entirely as a start and then move from there.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/2] ext4: Pass in DIO_SKIP_DIO_COUNT flag if  inode_dio_begin() called Christoph Hellwig <hch@infradead.org> - 2016-04-20 23:00 +0200
  Re: [PATCH v3 1/2] ext4: Pass in DIO_SKIP_DIO_COUNT flag if inode_dio_begin()  called Waiman Long <waiman.long@hpe.com> - 2016-04-21 20:20 +0200
    Re: [PATCH v3 1/2] ext4: Pass in DIO_SKIP_DIO_COUNT flag if  inode_dio_begin() called Christoph Hellwig <hch@infradead.org> - 2016-04-25 13:50 +0200
      Re: [PATCH v3 1/2] ext4: Pass in DIO_SKIP_DIO_COUNT flag if inode_dio_begin()  called Waiman Long <waiman.long@hpe.com> - 2016-04-26 18:40 +0200

csiph-web